Dispute modifications#60
Merged
LeoHChen merged 33 commits intostoryprotocol:mainfrom Apr 12, 2024
Merged
Conversation
Spablob
changed the title
Spablob
requested review from
AndyBoWu,
LeoHChen,
Ramarti,
jdubpark,
kingster-will and
leeren
as code owners
Merged
LeoHChen
requested changes
Apr 11, 2024
LeoHChen
left a comment
LeoHChen
left a comment
There was a problem hiding this comment.
This one should be split into two PRs. One for Dispute modification and one for Royalty fix.
Ramarti
reviewed
Apr 11, 2024
jdubpark
reviewed
Apr 11, 2024
LeoHChen
reviewed
Apr 11, 2024
LeoHChen
reviewed
Apr 11, 2024
* Add licensing tests * Add More tests
* Refactor Governance into AccessManager (storyprotocol#43) * refactor Governance into AccessManager * remove view method in script * [feat] add reusable forge code coverage workflow --------- Co-authored-by: Ramarti <raul.mf86@gmail.com>
Spablob
changed the title
Author
Removed royalty-related fixes from the pr in 1520309 |
LeoHChen
reviewed
Apr 12, 2024
LeoHChen
reviewed
Apr 12, 2024
LeoHChen
approved these changes
Apr 12, 2024
kingster-will
approved these changes
Apr 12, 2024
LeoHChen
approved these changes
Apr 12, 2024
jdubpark
added a commit
to jdubpark/sp-protocol-core
that referenced
this pull request
Apr 14, 2024
* add new tagDerivativeIfParentInfringed function * format fix * rebase: eliminate data uniqueness * fix rebase duplication * revert royalty related fixes * format fix * add business logic comments * add restriction clarifications * fix comment size --------- Co-authored-by: Jongwon Park <contact@parkjongwon.com> Co-authored-by: kingster-will <83567446+kingster-will@users.noreply.github.com> Co-authored-by: Andy Wu <bwu2sfu@gmail.com> Co-authored-by: Ramarti <raul.mf86@gmail.com>
kingster-will
pushed a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 31, 2025
…ent is higher than zero (storyprotocol#60)
kingster-will
pushed a commit
that referenced
this pull request
Jan 31, 2025
…ent is higher than zero (#60)
irfand29
pushed a commit
to irfand29/protocol-core-v1
that referenced
this pull request
Feb 8, 2025
…ent is higher than zero (storyprotocol#60)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispute adjustments
Other fixes