This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Avoid creating a lot of MetadataCache instances #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Aug 18, 2021
BewareMyPower
added a commit
that referenced
this pull request
Aug 19, 2021
### Motivation When there're a lot of topics, there could be a lot of `MetadataCache` instances in memory.  This bug was introduced from #488 because the Pulsar side adopted a new class `MetadataCache` as ZK cache. However, each time `MetadataStore#getMetadataCache` is called, a new `MetadataCache` instance will be created. In KoP, it means that each time a topic lookup is performed, a new `MetadataCache` instance will be created. ### Modifications Only call `MetadataStore#getMetadataCache` once when KoP starts and reuse the same `MetadataCache` instance for each `KafkaRequestHandler` instance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When there're a lot of topics, there could be a lot of
MetadataCacheinstances in memory.This bug was introduced from #488 because the Pulsar side adopted a new class
MetadataCacheas ZK cache. However, each timeMetadataStore#getMetadataCacheis called, a newMetadataCacheinstance will be created. In KoP, it means that each time a topic lookup is performed, a newMetadataCacheinstance will be created.Modifications
Only call
MetadataStore#getMetadataCacheonce when KoP starts and reuse the sameMetadataCacheinstance for eachKafkaRequestHandlerinstance.