Skip to content

Commit 77033ec

Browse files
authored
fix(sdk): Fix circular dependency by removing redundant tsyringe setup import from PersistenceManager (#3367)
## Summary Fix a circular dependency in the SDK by removing a redundant `import './setupTsyringe'` statement from `PersistenceManager.ts`. The circular dependency chain was: 1. `PersistenceManager.ts` imports `setupTsyringe.ts` 2. `setupTsyringe.ts` imports `Resends.ts` (to register it with tsyringe) 3. `Resends.ts` transitively depends on `PersistenceManager` through the dependency injection graph Since `setupTsyringe.ts` is already imported at the application entry point (`StreamrClient.ts`), the import in `PersistenceManager.ts` was redundant and only served to create this circular reference. ## Changes - Remove unnecessary `import './setupTsyringe'` from `packages/sdk/src/PersistenceManager.ts`
1 parent 9a110cf commit 77033ec

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

packages/sdk/src/PersistenceManager.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import './setupTsyringe'
2-
31
import { join } from 'path'
42
import { inject, Lifecycle, scoped } from 'tsyringe'
53
import { Identity, IdentityInjectionToken } from './identity/Identity'

0 commit comments

Comments
 (0)