fix(sdk): Fix circular dependency by removing redundant tsyringe setup import from PersistenceManager#3367
Merged
mondoreale merged 1 commit intomainfrom Jan 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a circular dependency in the SDK by removing a redundant import './setupTsyringe' statement from PersistenceManager.ts. The circular dependency chain was: PersistenceManager → setupTsyringe → Resends → MessagePipelineFactory → GroupKeyManager → LocalGroupKeyStore → PersistenceManager. Since setupTsyringe is already imported at the application entry point (StreamrClient.ts), this import was unnecessary.
Changes:
- Removed redundant
import './setupTsyringe'statement fromPersistenceManager.ts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a circular dependency in the SDK by removing a redundant
import './setupTsyringe'statement fromPersistenceManager.ts.The circular dependency chain was:
PersistenceManager.tsimportssetupTsyringe.tssetupTsyringe.tsimportsResends.ts(to register it with tsyringe)Resends.tstransitively depends onPersistenceManagerthrough the dependency injection graphSince
setupTsyringe.tsis already imported at the application entry point (StreamrClient.ts), the import inPersistenceManager.tswas redundant and only served to create this circular reference.Changes
import './setupTsyringe'frompackages/sdk/src/PersistenceManager.ts