Merged
Conversation
39b8b4e to
a33acb6
Compare
juslesan
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed obsolete
NetworkNodeConfig#idconfig option. TheNetworkNodeConfiginterface corresponds theContentDeliveryManagerOptionsinterface intrackerless-network, and there is noidfield in that interface. Therefore the config option doesn't configure anything and is obsolete.Background
The description of the removed config option was "the Ethereum address of the node". Therefore it is likely that the config option is from pre-
trackerless-networkera. In that implementation node ids were Ethereum addresses.Other changes
Fixed config injection problem in
OperatorPlugintest. When the "invalid configuration" test case modified the config object returned byformConfig, it modified also theTEST_CONFIGobject (becauseTEST_CONFIGobject properties are injected by reference informConfig). That caused another test in theOperatorPluginto fail.formConfig. But as cloning is needed only in this one test case, maybe better to do it locally.