feat(sdk)!: Stream#update() doesn't merge#2826
Merged
Conversation
harbu
approved these changes
Oct 21, 2024
harbu
reviewed
Oct 21, 2024
…ream-update-doesnt-merge
harbu
approved these changes
Oct 24, 2024
Base automatically changed from
sdk-Stream-metadata-partitions-is-nullable
to
main
October 24, 2024 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change
The
Stream#update()doesn't merge the metadata with the existing data. It simply overwrites the existing data with the new data.Now
Stream#update()andStreamrClient#updateStream()have almost the same functionality.Future improvements
Maybe the two methods should have exactly the same functions: i.e. we'd clear the cache also in
StreamrClient#updateStream().