Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a bundling pipeline for the proto-rpc package using Rollup to generate optimized CommonJS and ES module outputs with bundled type definitions. The changes modernize the build process and improve the package's distribution structure.
Key changes:
- Implemented Rollup-based bundling with both CJS and ESM outputs
- Updated TypeScript configuration to use
module: preserveandmoduleResolution: bundlerfor better bundler support - Added cleanup and build orchestration scripts with rimraf and tsx
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/proto-rpc/rollup.config.mts | New Rollup configuration defining build outputs for both JavaScript formats and type definitions |
| packages/proto-rpc/package.json | Updated entry points, build scripts, and dependencies to support the new bundling workflow |
| packages/proto-rpc/tsconfig.json | Modified TypeScript module settings to align with bundler-based resolution |
| package-lock.json | Dependency lockfile updates for new rollup-related packages and rimraf |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build and packaging pipeline for the
proto-rpcpackage to improve module output, type bundling, and cleanup. The changes introduce Rollup for bundling, refine the output structure, and add supporting scripts and dependencies.Build and packaging improvements:
rollup.config.mtsconfiguration file to bundle both CommonJS (exports.cjs) and ES module (exports.js) outputs, as well as generate bundled type definitions (exports.d.ts).package.jsonto pointmainto./dist/src/exports.cjs, add amoduleentry for ESM, and restrict the published files to only the bundled outputs.postbuildscript to run Rollup after TypeScript compilation, and areset-selfscript to clean up build artifacts before building.Dependency updates:
rollup,rollup-plugin-dts,@rollup/plugin-node-resolve,tsx, andrimraffor improved bundling and cleanup.TypeScript configuration:
tsconfig.jsonto usemodule: preserveandmoduleResolution: bundlerto better support the new bundling workflow.