feat: Add NotErrorAs method to {assert|require} packages#1137
Open
titusjaka wants to merge 1 commit intostretchr:masterfrom
Open
feat: Add NotErrorAs method to {assert|require} packages#1137titusjaka wants to merge 1 commit intostretchr:masterfrom
NotErrorAs method to {assert|require} packages#1137titusjaka wants to merge 1 commit intostretchr:masterfrom
Conversation
… err's chain matches target
|
I was just searching for this function, to discover it is missing. Maybe @boyan-soubachov could have a look? :-) |
|
+1 for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
NotErrorAsmethods to check that none of the errors in err's chain matches target.Changes
NotErrorAsandNotErrorAsfassertions toassertandrequirepackagesMotivation
Sometimes, it's essential to check that error does not match an exact type.
Related issues
Closes #1066