Closed
Conversation
Fix random failure TestEventuallyIssue805 due to timing dependency. Fix TestFailfastSuite when run with go test flag -count=X where X greater than 1.
Collaborator
|
Two unrelated changes in a single commit. This can't be merged as is. Commits across multiple packages should have a good reason, and this is not a good case. I also have independently written a fix for TestEventuallyIssu805 but not just by increasing delay. Could you review #1412? Please submit the change about the |
dolmen
added
test
pkg-assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix random test failure and compatibility with
go test -count=XwhereX > 1.Changes
TestFailfastSuitewhen run withgo testflag-count=XwhereX > 1.Motivation
So we don't get false test failures causing confusion.