test: add tests for unset call matching #1621#1622
Closed
techfg wants to merge 2 commits intostretchr:masterfrom
Closed
test: add tests for unset call matching #1621#1622techfg wants to merge 2 commits intostretchr:masterfrom
techfg wants to merge 2 commits intostretchr:masterfrom
Conversation
Collaborator
|
Looking into #1621 it appears the current behaviour is working as designed. I dislike the design, but specifically making Unset only unset its own Call instance will break the intended use case which is encoded in tests added with the feature: myMock.On(1).Return()
myMock.On(1).Return().Unset()
// There are now no expectations to be called with `1`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: The build for this PR is expected to fail as the PR currently only adds tests to reproduce the issues in #1621
Summary
Add tests to reproduce issues in #1621
Changes
Adds 5 tests to reproduce issue
Motivation
See #1621
Related issues
#1621