assert.Eventually: fail the testcase if condition is not met#838
Closed
dmacvicar wants to merge 1 commit intostretchr:masterfrom
Closed
assert.Eventually: fail the testcase if condition is not met#838dmacvicar wants to merge 1 commit intostretchr:masterfrom
dmacvicar wants to merge 1 commit intostretchr:masterfrom
Conversation
ghost
mentioned this pull request
Collaborator
|
@dmacvicar , please rebase onto master to make the tests pass on |
Contributor
|
This was superseded by #869 and should be closed |
dolmen
added
pkg-assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #837
See #837 (comment) for an explanation.
Given that the original tests did not catch the problem, I am not sure how to enhance the tests to do it. But feedback is appreciated.
I am also not completely sure if I am missing something regarding the motivation for f1bd092 change from
Failtofalse, or if it was just an oversight.