Skip to content

refactor: simplify MPP pay credential creation#19

Open
brendanjryan wants to merge 1 commit intostripe:mainfrom
brendanjryan:brendan/mppx-create-credential
Open

refactor: simplify MPP pay credential creation#19
brendanjryan wants to merge 1 commit intostripe:mainfrom
brendanjryan:brendan/mppx-create-credential

Conversation

@brendanjryan
Copy link
Copy Markdown
Contributor

@brendanjryan brendanjryan commented Apr 26, 2026

Summary

  • replaced the hand-rolled Stripe challenge reconstruction in mpp pay with a tiny mppx client method that uses Mppx.create(...).createCredential(...)
  • selected the Stripe charge challenge from the full 402 response via Challenge.fromResponseList(...) before building the credential
  • added a regression test covering a mixed tempo + stripe WWW-Authenticate header

@brendanjryan brendanjryan requested a review from a team as a code owner April 26, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants