Add arethetypeswrong to CI/publish scripts#597
Merged
fruchtose-stripe merged 1 commit intomasterfrom Apr 12, 2024
Merged
Conversation
fruchtose-stripe
requested review from
awalker-stripe,
dweedon-stripe and
tylersmith-stripe
and removed request for
tylersmith-stripe
awalker-stripe
previously approved these changes
Apr 12, 2024
fruchtose-stripe
force-pushed
the
fruchtose/arethetypeswrong-scripts
branch
from
8a9c30e to
32c19a0
Compare
awalker-stripe
approved these changes
Apr 12, 2024
This was referenced Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & motivation
This changeset makes future releases more resilient by checking for errors in published types at CI/publish stages.
Testing & documentation
I tested this by running the new script locally, both with valid and invalid type definitions in the
./liband./puredirectories.