fix: add tsup --shims for ESM/CJS dirname compatibility#308
Merged
kevcodez merged 1 commit intostripe:mainfrom Apr 6, 2026
Merged
fix: add tsup --shims for ESM/CJS dirname compatibility#308kevcodez merged 1 commit intostripe:mainfrom
kevcodez merged 1 commit intostripe:mainfrom
Conversation
Bare __dirname is a CJS-only global and is undefined in ESM contexts. Enable tsup --shims so both the ESM and CJS builds get proper polyfills for __dirname, __filename, and import.meta.url respectively. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kevcodez
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare __dirname is a CJS-only global and is undefined in ESM contexts.
This enables tsup --shims so the ESM build has __dirname.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Calling
runMigrations()in ESM returns "__dirname is not defined"What is the new behavior?
tsup generates shims so runMigrations() works both in CJS and EMS because __driname gets defined
Additional context
Note
I let Claude Code fix this and did not write code myself. I validated the changes in my ESM Project.
I hope this is ok for you.