This repository was archived by the owner on Feb 4, 2023. It is now read-only.
Add an AttributeColumn with data-* attributes#837
Merged
stephanvierkant merged 2 commits intostwe:masterfrom May 10, 2019
Merged
Add an AttributeColumn with data-* attributes#837stephanvierkant merged 2 commits intostwe:masterfrom
stephanvierkant merged 2 commits intostwe:masterfrom
Conversation
* a text column with attributes generated by the server for each row and displayed in the HTML in data-* attributes
This was referenced Oct 23, 2018
Merged
stephanvierkant
approved these changes
Dec 11, 2018
Collaborator
|
Thanks for your PR's! I think they are very useful. I haven't test them yet, but the code looks good on first sight! This library hasn't got a proper unit test right now. Are you willing to contribute by adding tests to your PR's? See #885. |
stephanvierkant
approved these changes
May 9, 2019
Collaborator
stephanvierkant
left a comment
stephanvierkant
left a comment
There was a problem hiding this comment.
Sorry it took this long, but this looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added the AttributeColumn which allows to create a column in which every cell contains a span tag with data-* attributes passed as parameters.