fix: resolve invalid CSS percentage value for lineHeight in RhythmRuler#6737
Open
CodeBySayak wants to merge 1 commit intosugarlabs:masterfrom
Open
fix: resolve invalid CSS percentage value for lineHeight in RhythmRuler#6737CodeBySayak wants to merge 1 commit intosugarlabs:masterfrom
CodeBySayak wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 42.54% | Branches: 35.12% | Functions: 46.7% | Lines: 42.95% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The RhythmRuler widget was setting an invalid CSS value for the
lineHeightproperty of its ruler cells. Injs/widgets/rhythmruler.js, the code was:rulerSubCell.style.lineHeight = 60 + " % ";
This produced the string "60 % ". According to CSS standards, percentage values must not contain whitespace between the number and the percent sign. This invalid syntax often causes browsers to ignore the property, leading to inconsistent vertical alignment of note labels within the cells.
Solution
Corrected the lineHeight assignment to a valid CSS percentage string:
rulerSubCell.style.lineHeight = "60%";
Changes
Impact
Type of Change
closes #6736