Skip to content

chore: improve RhythmBlocks branch coverage [#5607]#6738

Merged
walterbender merged 2 commits intosugarlabs:masterfrom
Mohd-Ali-Creator:fix/rhythm-blocks-coverage
Apr 20, 2026
Merged

chore: improve RhythmBlocks branch coverage [#5607]#6738
walterbender merged 2 commits intosugarlabs:masterfrom
Mohd-Ali-Creator:fix/rhythm-blocks-coverage

Conversation

@Mohd-Ali-Creator
Copy link
Copy Markdown
Contributor

Improves branch coverage for RhythmBlocks.js by adding
tests for previously uncovered paths.

Coverage improvement:

  • Statements: 66.22% → 73.11%
  • Branches: 54.28% → 58.09%
  • Lines: 72.62% → 80.29%

New tests added:

  • NoteBlock callback queue path (lines 193-197)
  • SwingBlock listener suppressOutput paths (lines 253-258)
  • NewSwingBlock flow and listener paths (lines 307-328)

All 35 tests passing ✅
Full suite: 4004/4004 green ✅

PR Category

  • Bug Fix - Fixes a bug or incorrect behavior
  • Feature - Adds new functionality
  • Performance - Improves performance
  • Tests - Adds or updates test coverage
  • Documentation - Updates to docs, comments, or README

@github-actions github-actions bot added tests Adds or updates test coverage size/M Medium: 50-249 lines changed area/javascript Changes to JS source files area/tests Changes to test files needs-rebase labels Apr 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR has merge conflicts with master.

Please rebase your branch:

# Add upstream remote (one-time setup)
git remote add upstream https://github.com/sugarlabs/musicblocks.git

# Fetch latest master and rebase
git fetch upstream
git rebase upstream/master

# Resolve any conflicts, then:
git push --force-with-lease origin YOUR_BRANCH

Tip: Enable "Allow edits from maintainers" on this PR so we can auto-rebase for you next time. This only grants access to your PR branch. Your fork's other branches are not affected.

@github-actions
Copy link
Copy Markdown
Contributor

✅ All Jest tests passed! This PR is ready to merge.

Coverage: Coverage summary unavailable

@Mohd-Ali-Creator Mohd-Ali-Creator force-pushed the fix/rhythm-blocks-coverage branch from e43c564 to 3dbbf86 Compare April 19, 2026 20:18
@github-actions
Copy link
Copy Markdown
Contributor

Merge conflicts resolved. Ready for review.

@github-actions github-actions bot added size/L Large: 250-499 lines changed and removed needs-rebase size/M Medium: 50-249 lines changed labels Apr 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ All Jest tests passed! This PR is ready to merge.

Coverage: Statements: 42.45% | Branches: 34.99% | Functions: 46.56% | Lines: 42.87%

@Mohd-Ali-Creator
Copy link
Copy Markdown
Contributor Author

Hi @vyagh @walterbender,

PR #6738 improves RhythmBlocks.js branch coverage.

Coverage improvement:

  • Statements: 66% → 73%
  • Branches: 54% → 58%
  • Lines: 72% → 80%

All 10 CI checks passing ✅

Could you please take a look when you get a chance? 🙏

@walterbender
Copy link
Copy Markdown
Member

Did you do a rebase before making this commit? It seems like lots of unrelated changes in the commit.

@Mohd-Ali-Creator
Copy link
Copy Markdown
Contributor Author

Hi @walterbender,

Apologies for the confusion! The previous commit
had unintended deletions due to a rebase conflict
resolution error.

Fixed: restored all upstream tests and added only
my new coverage tests on top.

Now: 65 tests passing, no deletions of existing tests.

Sorry for the trouble! 🙏

@github-actions github-actions bot added size/M Medium: 50-249 lines changed and removed size/L Large: 250-499 lines changed labels Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ All Jest tests passed! This PR is ready to merge.

Coverage: Statements: 42.55% | Branches: 35.13% | Functions: 46.72% | Lines: 42.96%

@walterbender walterbender merged commit 06c862a into sugarlabs:master Apr 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/javascript Changes to JS source files area/tests Changes to test files size/M Medium: 50-249 lines changed tests Adds or updates test coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants