chore: improve RhythmBlocks branch coverage [#5607]#6738
chore: improve RhythmBlocks branch coverage [#5607]#6738walterbender merged 2 commits intosugarlabs:masterfrom
Conversation
|
This PR has merge conflicts with Please rebase your branch: # Add upstream remote (one-time setup)
git remote add upstream https://github.com/sugarlabs/musicblocks.git
# Fetch latest master and rebase
git fetch upstream
git rebase upstream/master
# Resolve any conflicts, then:
git push --force-with-lease origin YOUR_BRANCH
|
|
✅ All Jest tests passed! This PR is ready to merge. Coverage: Coverage summary unavailable |
e43c564 to
3dbbf86
Compare
|
Merge conflicts resolved. Ready for review. |
|
✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 42.45% | Branches: 34.99% | Functions: 46.56% | Lines: 42.87% |
|
Hi @vyagh @walterbender, PR #6738 improves RhythmBlocks.js branch coverage. Coverage improvement:
All 10 CI checks passing ✅ Could you please take a look when you get a chance? 🙏 |
|
Did you do a rebase before making this commit? It seems like lots of unrelated changes in the commit. |
|
Hi @walterbender, Apologies for the confusion! The previous commit Fixed: restored all upstream tests and added only Now: 65 tests passing, no deletions of existing tests. Sorry for the trouble! 🙏 |
|
✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 42.55% | Branches: 35.13% | Functions: 46.72% | Lines: 42.96% |
Improves branch coverage for RhythmBlocks.js by adding
tests for previously uncovered paths.
Coverage improvement:
New tests added:
All 35 tests passing ✅
Full suite: 4004/4004 green ✅
PR Category