Use ratatui-image to show images in-terminal#44
Use ratatui-image to show images in-terminal#44chinatsu wants to merge 5 commits intosugyan:mainfrom
Conversation
i don't really like how check_path is growing, but that's where we originally read an image.. so... refactoring should maybe take place lol
91b56ab to
8eae727
Compare
|
I don't like it when branches live very long, so maybe it's best if we limit the feature scope for this PR. It seems a little bare to leave it the way it is now, though. |
|
Thanks for the great suggestion and implementation. Also, since the column width can be flexibly changed, I thought it would be necessary to consider many aspects of UI design to make it possible to display the columns without making them difficult to see even when they are narrow. If it is not a problem from a UI standpoint, I would be happy to add, as you write, previewing embeds when creating a post. |
|
It sounds like we're pretty aligned! I personally would love to see posted images near the feed as well, but I'll skip looking into that in this PR. |
It would be nice to see images in-situ for terminals that support images. It seems ratatui-image handles various terminals pretty well, so the usage is pretty simple.
I've not really thought this through very well, and I'm not really sure I've got the motivation or knowledge to see this PR through to a ready state.
I'm not super familiar with this program yet. I started using it today. So I might not know the ins and outs of the way the architecture is meant to work.
The initial commit is only a simple test to see if it's possible at all, and I think I kind of like it!