Skip to content

Comments

fix: correctly cleanup metrics tables#610

Merged
hauleth merged 1 commit intomainfrom
correctly-cleanup-metric-tables
Feb 24, 2025
Merged

fix: correctly cleanup metrics tables#610
hauleth merged 1 commit intomainfrom
correctly-cleanup-metric-tables

Conversation

@hauleth
Copy link
Contributor

@hauleth hauleth commented Feb 24, 2025

No description provided.

@hauleth hauleth requested a review from a team as a code owner February 24, 2025 12:01
Copy link
Member

@filipecabaco filipecabaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity why handle continue vs handle info ?

@hauleth
Copy link
Contributor Author

hauleth commented Feb 24, 2025

handle_info calls handle_continue, and the reason for that is to deduplicate code.

@hauleth hauleth force-pushed the correctly-cleanup-metric-tables branch from e3973bd to 1b28d6b Compare February 24, 2025 12:06
@hauleth hauleth force-pushed the correctly-cleanup-metric-tables branch from 1b28d6b to ee9e447 Compare February 24, 2025 12:07
@hauleth hauleth merged commit e2a9912 into main Feb 24, 2025
8 checks passed
@hauleth hauleth deleted the correctly-cleanup-metric-tables branch February 24, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants