Conversation
hauleth
force-pushed
the
cleanup-metrics-gathering
branch
from
0671dc9 to
96b559e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hauleth
force-pushed
the
cleanup-metrics-gathering
branch
3 times, most recently
from
ed0221d to
a1311e8
Compare
Instead of fetching metrics results as a binary and then doing some magic to add global tags and to merge them, merge them in their basic form as produced by the `Peep` and then generate report from that on target node. This should resolve a lot of problems related to the output format issues.
hauleth
force-pushed
the
cleanup-metrics-gathering
branch
from
07aa2b4 to
5f77f88
Compare
| end | ||
|
|
||
| defp gen_token(secret \\ Application.fetch_env!(:supavisor, :metrics_jwt_secret)) do | ||
| Supavisor.Jwt.Token.gen!(secret) |
Check notice
Code scanning / Credo
Nested modules could be aliased at the top of the invoking module. Note test
chasers
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of fetching metrics results as a binary and then doing some magic to add global tags and to merge them, merge them in their basic form as produced by the
Peepand then generate report from that on target node. This should resolve a lot of problems related to the output format issues.