fix(logger): format mfas in accordance to logflare, put level in meta#667
Merged
fix(logger): format mfas in accordance to logflare, put level in meta#667
Conversation
v0idpwn
commented
Jun 19, 2025
| @impl true | ||
| def format(%{msg: msg, level: level, meta: meta}, opts) do | ||
| context_keys = [Map.get(opts, :context, []) | @default_context] | ||
| context_keys = Map.get(opts, :context, []) ++ @default_context |
Member
Author
There was a problem hiding this comment.
This was also broken, the keys went outside of context because the list wasn't properly merged
chasers
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Changes file log formatting to conform to Logflare's format.
What is the current behavior?
Because MFAs have a mix of strings and integers, ingestion fails. Also, the log level is on top level, but logflare expects it to be inside metadata, so it wouldn't get picked up.
What is the new behavior?
Added a pass to perform arbitrary transformations.
Additional context
Tested in staging