refactor: replace Readdir(-1) with os.ReadDir#147
Merged
benbjohnson merged 1 commit intosuperfly:mainfrom Oct 28, 2022
Juneezee:refactor/os.ReadDir
Merged
refactor: replace Readdir(-1) with os.ReadDir#147benbjohnson merged 1 commit intosuperfly:mainfrom Juneezee:refactor/os.ReadDir
Readdir(-1) with os.ReadDir#147benbjohnson merged 1 commit intosuperfly:mainfrom
Juneezee:refactor/os.ReadDir
Conversation
The following code block
f, err := os.Open(dirname)
if err != nil {
return err
}
defer f.Close()
fis, err := f.Readdir(-1)
can be replaced with just `os.ReadDir(dirname)`.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code block
can be replaced with just
os.ReadDir(dirname).