Skip to content

Skip dirty page tracking in WAL mode #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbjohnson merged 1 commit into from
Nov 25, 2022
Merged

Skip dirty page tracking in WAL mode #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,9 +529,13 @@ func (db *DB) WriteDatabase(f *os.File, data []byte, offset int64) error {
db.pageSize = hdr.PageSize
}

// Mark page as dirty.
pgno := uint32(offset/int64(db.pageSize)) + 1
db.dirtyPageSet[pgno] = struct{}{}
// Track dirty pages if we are using a rollback journal. This isn't
// necessary with the write-ahead log (WAL) since pages are appended
// instead of overwritten. We can determine the dirty set at commit-time.
if db.mode == DBModeRollback {
pgno := uint32(offset/int64(db.pageSize)) + 1
db.dirtyPageSet[pgno] = struct{}{}
}

// Callback to perform write on handle.
if _, err := f.WriteAt(data, offset); err != nil {
Expand Down