Move WAL commit to after WAL_WRITE_LOCK release#205
Merged
benbjohnson merged 1 commit intomainfrom Nov 29, 2022
Merged
Conversation
benbjohnson
force-pushed
the
fix-wal-commit
branch
from
dd4a1ea to
2cce535
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug where the WAL segment is computed before the transaction fully completes. This can occur because SQLite can rewrite sections of the WAL as needed and then rewrites frame headers at the end. This can cause the database & the LTX files to become out of sync and cause
checksum mismatcherrors.LiteFS now waits for
WAL_WRITE_LOCKto be released before computing the transaction's pages. This ensures that the final version of the frames are written before determining the transaction boundaries.