Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/survey-core/src/itemvalue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,8 @@ export class ItemValue extends BaseAction implements ILocalizableOwner, IShortcu
if (this.getType() != this.getBaseType()) {
CustomPropertiesCollection.createProperties(this);
}
this.onCreating();
}

public onCreating(): any { }
public getType(): string {
return this.typeName || this.getBaseType();
}
Expand Down
2 changes: 0 additions & 2 deletions packages/survey-core/src/localizablestring.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ export class LocalizableString implements ILocalizableString {
constructor(public owner: ILocalizableOwner, public useMarkdown: boolean = false,
public name?: string, locName?: string) {
this._localizationName = locName;
this.onCreating();
}
public getIsMultiple(): boolean { return false; }
public getStringViewerClassName(textClass?: string): string {
Expand Down Expand Up @@ -408,7 +407,6 @@ export class LocalizableString implements ILocalizableString {
}
public onChanged(): void { }
public onStringChanged: EventBase<LocalizableString> = new EventBase<LocalizableString>();
protected onCreating(): void { }
private hasHtmlValue(): boolean {
if (!this.owner || !this.useMarkdown) return false;
let loc = this.locale;
Expand Down
2 changes: 0 additions & 2 deletions packages/survey-core/src/popup-survey.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export class PopupSurveyModel extends Base {
this.width = <any>new ComputedUpdater<string>(() => this.survey.width);
this.width = this.survey.width;
this.updateCss();
this.onCreating();
}
protected onPropertyValueChanged(name: string, oldValue: any, newValue: any): void {
super.onPropertyValueChanged(name, oldValue, newValue);
Expand All @@ -44,7 +43,6 @@ export class PopupSurveyModel extends Base {
this.onExpandedChanged();
}
}
protected onCreating(): void { }
public getType(): string {
return "popupsurvey";
}
Expand Down
7 changes: 0 additions & 7 deletions packages/survey-core/src/survey.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,6 @@ export class SurveyModel extends SurveyElementCore

constructor(jsonObj: any = null, renderedElement: any = null) {
super();
this.onBeforeRunConstructor();

this.createNewArray(
"pages",
Expand Down Expand Up @@ -1156,7 +1155,6 @@ export class SurveyModel extends SurveyElementCore
this.rebuildQuestionChoices();
};
this.locTitle.onStringChanged.add(() => this.resetPropertyValue("titleIsEmpty"));
this.onBeforeCreating();
if (jsonObj) {
if (typeof jsonObj === "string" || jsonObj instanceof String) {
jsonObj = JSON.parse(jsonObj as string);
Expand All @@ -1169,7 +1167,6 @@ export class SurveyModel extends SurveyElementCore
this.loadSurveyFromService(this.surveyId, this.clientId);
}
}
this.onCreating();
if (!!renderedElement) {
this.render(renderedElement);
}
Expand Down Expand Up @@ -7069,10 +7066,6 @@ export class SurveyModel extends SurveyElementCore
this.setCalculatedWidthModeUpdater();
this.onEndLoadingFromJson.fire(this, {});
}

protected onBeforeRunConstructor() {}
protected onBeforeCreating() { }
protected onCreating() { }
private getProcessedTextValue(textValue: TextPreProcessorValue): void {
this.getProcessedTextValueCore(textValue);
if (!this.onProcessDynamicText.isEmpty) {
Expand Down
2 changes: 0 additions & 2 deletions packages/survey-core/src/surveyTimerModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,13 @@ export class SurveyTimerModel extends Base {
constructor(survey: ISurvey) {
super();
this.surveyValue = survey;
this.onCreating();
}
@property() text: string;
@property() progress: number;
@property() clockMajorText: string;
@property() clockMinorText: string;
@property({ defaultValue: 0 }) spent: number;
public get survey(): ISurveyTimerText { return <any>this.surveyValue; }
public onCreating(): void { }
private timerFunc: any = null;
public start(): void {
if (!this.survey) return;
Expand Down