Implement support for multiple modal windows#10844
Merged
Conversation
novikov82
approved these changes
Jan 23, 2026
MarchTokenda
added a commit
that referenced
this pull request
Jan 26, 2026
commit 7a87088 Author: Dmitry Kurmanov <kurmanov.work@gmail.com> Date: Mon Jan 26 16:02:12 2026 +0400 PR: ranking RTL (#10853) * Ranking Question with selective ranking feature ("selectToRankEnabled") - It's impossible to drop more than one item to the rank are in RTL #10837 * Ranking Question with selective ranking feature ("selectToRankEnabled") - It's impossible to drop more than one item to the rank are in RTL #10837 commit aec0606 Author: Dmitry <dk981234@gmail.com> Date: Mon Jan 26 14:59:43 2026 +0700 Fix top navigation padding for mobile layout (#10848) commit 32f0d94 Author: Andrew <andrew.telnov@gmail.com> Date: Mon Jan 26 08:12:31 2026 +0200 The dataList property value is not saved in a survey JSON definition fix #10849 (#10850) commit 964dc0a Author: MarchTokenda <98102580+MarchTokenda@users.noreply.github.com> Date: Mon Jan 26 08:11:37 2026 +0200 validateExpressions() returns internal validator instead of survey element + TS docs example is invalid fix #10840 (#10843) * try to overwrite validateExpressions + added tests WIP * Fix unit tests --------- Co-authored-by: Dmitrii Gerasimov <dima@rimmon.dev> Co-authored-by: Andrew Telnov <andrew.telnov@gmail.com> commit 6e9868d Author: Andrew <andrew.telnov@gmail.com> Date: Mon Jan 26 08:10:51 2026 +0200 fromJSON() with validatePropertyValues: true produces an error when the choices property is defined as a function that references the object instance & callback function fix #10845 (#10846) commit 4ff7e23 Author: Aleksey Novikov <novikov82@gmail.com> Date: Mon Jan 26 09:09:34 2026 +0300 * #8030 Input Validation for Masked Fields Fixes #8030 * #8030 - f-test * #8030 commit 3298893 Author: Dmitry <dk981234@gmail.com> Date: Mon Jan 26 13:06:59 2026 +0700 Implement support for multiple modal windows (#10844) * Implement support for multiple modal windows * PopupModalManager class * Fix modal removal logic in Angular and ensure visibility state is set correctly commit 8c0b69a Author: Dmitry Kurmanov <kurmanov.work@gmail.com> Date: Thu Jan 22 18:58:19 2026 +0400 PR: Refactoring: Move all shadowDOM duplicated checks to helper (#10832) * Refactoring: Move all shadowDOM duplicated checks to helper surveyjs/private-tasks#515 * Refactoring: Move all shadowDOM duplicated checks to helper surveyjs/private-tasks#515 * Refactoring: Move all shadowDOM duplicated checks to helper surveyjs/private-tasks#515 * Refactoring: Move all shadowDOM duplicated checks to helper surveyjs/private-tasks#515 commit fce6979 Author: Dmitry Kurmanov <kurmanov.work@gmail.com> Date: Thu Jan 22 18:32:10 2026 +0400 PR: some our css selectors like [dir=rtl] applied on document ot body in our .scss files and will not work in shadow dom mode (#10833) * some our css selectors like [dir=rtl] applied on document ot body in our .scss files and will not work in shadow dom mode surveyjs/private-tasks#514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.