Skip to content

notcontains for empty arrays fix #10869 #10872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewtelnov merged 1 commit into from
Feb 3, 2026
Merged

notcontains for empty arrays fix #10869 #10872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/survey-core/src/expressions/expressions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,11 +644,10 @@ export class OperandMaker {
return true;
},
containsCore: function(left: any, right: any, isContains: any): boolean {
if (Array.isArray(left) && !left.length) return !isContains;
if (!left && left !== 0 && left !== false) return false;
if (!left.length) {
left = left.toString();
if (typeof right === "string" || right instanceof String) {
}
}
if (typeof left === "string" || left instanceof String) {
if (!right) return false;
Expand Down
12 changes: 12 additions & 0 deletions packages/survey-core/tests/expressions/expressionParserTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,18 @@ QUnit.test("Condition: on item - no spaces", function(assert) {
assert.equal(expr.evaluate(), true);
});

QUnit.test("[] notcontains 0 returns false #10869", (assert) => {
let runner = new ConditionRunner("{a} notcontains 0");
assert.equal(runner.runValues({ a: [] }), true, "[] notcontains 0");
assert.equal(runner.runValues({ a: [1, 2] }), true, "[1,2] notcontains 0");
assert.equal(runner.runValues({ a: [0, 1] }), false, "[0,1] notcontains 0");

runner = new ConditionRunner("{a} notcontains '0'");
assert.equal(runner.runValues({ a: [] }), true, "[] notcontains '0'");
assert.equal(runner.runValues({ a: [1, 2] }), true, "[1,2] notcontains '0'");
assert.equal(runner.runValues({ a: [0, 1] }), false, "[0,1] notcontains '0'");
});

QUnit.test("Run one condition", function(assert) {
var runner = new ConditionRunner("{a} > 5");
var values = { a: 6 };
Expand Down