Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/survey-core/src/question_paneldynamic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2467,6 +2467,7 @@ export class QuestionPanelDynamicModel extends Question
private isSetPanelItemData: HashTable<number> = {};
private static maxCheckCount = 3;
setPanelItemData(item: ISurveyData, name: string, val: any): void {
if (item === this.template.data) return;
if (this.isSetPanelItemData[name] > this.maxCheckCount)
return;
if (!this.isSetPanelItemData[name]) {
Expand Down
25 changes: 25 additions & 0 deletions packages/survey-core/tests/expressions/expressionValidationTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -803,3 +803,28 @@ QUnit.test("validate expressions in empty matrixdynamic by arrays, but with set
let results = survey.validateExpressions({ functions: true, variables: true, semantics: true });
assert.equal(results.length, 0, "There are 0 invalid expressions");
});
QUnit.test("validateExpressions() creates extra panel instances when defaultValue set on question inside templateElements[], Bug#10881", (assert) => {
const survey = new SurveyModel();
survey.fromJSON({
elements: [
{
type: "paneldynamic",
name: "q1",
panelCount: 1,
templateElements: [
{
type: "text",
name: "q2",
inputType: "number",
defaultValue: 1
},
],
}
],
});
const q1 = survey.getQuestionByName("q1");
assert.equal(q1.panelCount, 1, "panelCount is 1 before validateExpressions");
const results = survey.validateExpressions({ functions: true, variables: true, semantics: true });
assert.equal(results.length, 0, "There are 0 invalid expressions");
assert.equal(q1.panelCount, 1, "panelCount is 1 after validateExpressions");
});