Skip to content

Fix/prefix ids sameline comments #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SethFalco merged 3 commits into from
Jan 23, 2024
Merged

Fix/prefix ids sameline comments #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
878d7f5
Ignore vim swap files
john-neptune Jan 22, 2024
8cefdbe
Fix prefixing classes on same line as a comment
john-neptune Jan 22, 2024
5143387
Update .gitignore
john-neptune Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,11 @@ coverage
.DS_Store
.vscode
*.log

# https://github.com/github/gitignore/blob/main/Global/Vim.gitignore
[._]*.s[a-v][a-z]
!*.svg # comment out if you don't need vector files
[._]*.sw[a-p]
[._]s[a-rt-v][a-z]
[._]ss[a-gi-z]
[._]sw[a-p]
1 change: 0 additions & 1 deletion plugins/prefixIds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ export const fn = (_root, params, info) => {
});

child.value = csstree.generate(cssAst);
return;
}
}

Expand Down
23 changes: 23 additions & 0 deletions test/plugins/prefixIds.13.svg.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
Prefix IDs should apply to all nodes in styles, namely when styles are split
into multiple nodes due to XML comments.

===

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1 1">
<style>
<!-- uwu -->
#a13 {} <!-- xyz -->
#b13 {}
</style>
</svg>

@@@

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1 1">
<style>
<!--uwu-->
#prefixIds_13_svg_txt__a13{}
<!--xyz-->
#prefixIds_13_svg_txt__b13{}
</style>
</svg>