BUG: SmapiClient does not store new token on tokenRefreshRequired fault

[grougy]

What happened

SmapiClient does not refresh token

What did you expect to happen

SmapiClient should take the new token when faultstring is tokenRefreshRequired

How to reproduce it (minimal and precise)

Use Spotify service, wait for some time to call again some getMetada

Debug logging

See faultCode is not a string but an object, what the class is looking for is into #text

sonos:smapi:Spotify Soap error getMetadata { faultcode: { '#text': 'ns0:Client.TokenRefreshRequired' }, faultstring: { lang: 'en', '#text': 'tokenRefreshRequired' }, ...

changing all conditions to err.Fault.faultstring['#text'] === SmapiClientErrors.TokenRefreshRequiredError seems to fix the issue on my side, but is it specific to Spotify ? or my env ?

Environment

• sonos-ts version: 2.6.0-beta.11
• OS: Ubuntu 22
• node version (node -v): v20.17.0

Checklist

Please confirm the following before creating the issue.

• Environment specified
• Checked issues for duplicates
• Debug log added

[svrooij]

Are you maybe willing to contribute your fix for this? Start with the beta branch and create the pr for the beta branch, then I'm happy to review.

[grougy]

Hello, yes i can try that. I have just discovered the lib.
I will need time to understand it a bit more before to propose a fix: is it a XML parser issue, is it specific to Spotify or my case, related to a change in the beta, etc.

[svrooij]

@grougy I think no body is using the smapi stuff. Because this has been broken since the upgrade to the new xml parser library.

In the latest beta (to be released automatically soon), this issue is fixed. Will move this new beta to main also soon and then everything is back updated

[grougy]

Hello, sorry took me some time to come back testing the fix.

Looks good but one line remains to fix for token refresh to operate properly (Using Spotify)

Made a small PR that time ;-)

[grougy]

Hello @svrooij , any chance you could have a look to have this in the next beta?

[svrooij]

Sorry @grougy I completely lost track of this project. The last commit is a long time ago.

I still hate node and the trouble with xml parsing annoyed me a lot.

My limited time is currently focused on another sonos related project, where I'm working on music services as we speak. https://github.com/svrooij/sonos-net/tree/feature/net8

Will try to look at your pr this week.