Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/style/_authorize.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
.btn-done {
margin-right: 1em;
}

.authorize {
display: flex;
}
}

.auth-wrapper {
Expand Down
25 changes: 25 additions & 0 deletions test/e2e-cypress/e2e/bugs/6649.cy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
describe("#6649: Authorize popup buttons should not overlap", () => {
it("should render authorize and close buttons without overlapping", () => {
cy
.visit("/?url=/documents/bugs/4641.yaml")
.get("button.btn.authorize")
.click()
.get(".auth-btn-wrapper")
.should("be.visible")
.within(() => {
cy.get(".btn.authorize").then(($authorize) => {
cy.get(".btn-done").then(($close) => {
const authorizeRect = $authorize[0].getBoundingClientRect()
const closeRect = $close[0].getBoundingClientRect()

// The authorize button should end before the close button starts
// (no horizontal overlap)
expect(
authorizeRect.right,
"authorize button right edge should be at or before close button left edge"
).to.be.at.most(closeRect.left)
})
})
})
})
})