test(auth): add regression tests for relative OAuth2 URLs#10805
Open
maruthang wants to merge 2 commits intoswagger-api:masterfrom
Open
test(auth): add regression tests for relative OAuth2 URLs#10805maruthang wants to merge 2 commits intoswagger-api:masterfrom
maruthang wants to merge 2 commits intoswagger-api:masterfrom
Conversation
Add tests to prevent regression of relative OAuth2 URL handling that was broken in v5.20.0. Tests cover sanitizeUrl with various relative path patterns and the full OAuth2 authorize flow with dot-relative paths. Ref swagger-api#10340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add regression tests to prevent the relative OAuth2 URL handling bug from recurring. The bug was introduced in v5.20.0 (commit 80d56c9) and fixed in v5.27.0/v5.30.3, but had no test coverage to prevent regression.
New tests cover:
sanitizeUrlwith various relative path patterns (./../,../,../../,./,/, with query params)currentServerMotivation and Context
Ref #10340
The original bug broke relative OAuth2 authorization URLs (e.g.,
./../identity/connect/authorize). While the fix is already on master, there were no tests to prevent this from regressing again.How Has This Been Tested?
sanitizeUrlimplementationScreenshots (if appropriate):
N/A
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests