fix(oas3): reset request body when content type changes#10816
Open
maruthang wants to merge 1 commit intoswagger-api:masterfrom
Open
fix(oas3): reset request body when content type changes#10816maruthang wants to merge 1 commit intoswagger-api:masterfrom
maruthang wants to merge 1 commit intoswagger-api:masterfrom
Conversation
Removed the hasUserEditedBody guard in onChangeMediaType so the request body always resets when switching content types (unless shouldRetainRequestBodyValue is true). Response, request, and validation state is always cleared regardless of prior edits. Fixes swagger-api#9699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed the
hasUserEditedBodyguard inonChangeMediaTypeso the request body always resets when switching content types (unlessshouldRetainRequestBodyValueis true). Response, request, and validation state is always cleared regardless of whether the user has previously edited the body.Motivation and Context
Fixes #9699
When changing the content type in Try-It-Out mode, the request body retained the previous content type's value instead of resetting to the new content type's default. For example, switching from
application/jsontoapplication/x-www-form-urlencodedwould keep the JSON body, causing confusion and invalid requests. The root cause was ahasUserEditedBodycheck that prevented the body from being reset once the user had made any edit.How Has This Been Tested?
test/unit/components/parameters.jsxthat verifies the request body is reset when the content type changes, even after the user has edited the body.--no-verify(Husky exec format error on Windows — see memory notes).shouldRetainRequestBodyValueselector to ensure backward compatibility.Screenshots (if appropriate):
N/A — no visual changes.
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests