fix(core): deduplicate parameters by name and location, not just name#10820
Open
maruthang wants to merge 1 commit intoswagger-api:masterfrom
Open
fix(core): deduplicate parameters by name and location, not just name#10820maruthang wants to merge 1 commit intoswagger-api:masterfrom
maruthang wants to merge 1 commit intoswagger-api:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a path-level parameter and an operation-level parameter share the same
namebut have differentinlocations (e.g.,idin path vsidin header), swagger-client's normalize function deduplicates bynamealone, causing the path-level parameter to be dropped from the UI.This PR adds logic in
operation.jsxto fetch path-level parameters from the original spec JSON and merge any missing parameters into the operation's parameter list, using bothnameANDinas the deduplication key. This ensures parameters with the same name but different locations are all displayed correctly.Motivation and Context
Fixes #7430
The OpenAPI specification allows parameters with the same name in different locations (path, query, header, cookie). The current deduplication logic only checks
name, which violates the spec and causes valid path-level parameters to disappear from the UI when an operation-level parameter has the same name in a different location.How Has This Been Tested?
test/unit/bugs/7430-parameter-dedup-location.jsxthat constructs a spec with both a path-levelid(in: path) and an operation-levelid(in: header), verifying both parameters appear in the rendered output.--no-verify(Husky hook not compatible with this Windows environment).Screenshots (if appropriate):
N/A — no visual design changes, only logic fix for parameter display.
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests