fix(validation): handle anyOf/oneOf schemas in required parameter validation#10821
Open
maruthang wants to merge 1 commit intoswagger-api:masterfrom
Open
fix(validation): handle anyOf/oneOf schemas in required parameter validation#10821maruthang wants to merge 1 commit intoswagger-api:masterfrom
maruthang wants to merge 1 commit intoswagger-api:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a required path parameter uses an
anyOforoneOfcomposite schema without a directtypeproperty,validateParamnow derives the type from the first sub-schema. This ensures type-specific validation applies correctly and prevents JS errors whenswagger-client'sbuildRequestreceives incomplete parameters.Changes:
src/core/utils/index.js: InvalidateParam, added logic to check foranyOf/oneOfsub-schemas whenparamDetailshas no directtype, and set the type from the first sub-schema.test/unit/core/utils.js: Added 2 regression tests covering required parameters withanyOfandoneOfschemas (missing value, valid integer, valid string).Motivation and Context
Fixes #5831
Required parameters with
anyOf/oneOfschemas caused JS errors becausevalidateParamcouldn't determine the parameter type for validation. Without atypeon the top-level schema, the validation logic fell through without applying type-specific checks, which led to errors downstream whenswagger-client'sbuildRequestreceived incomplete parameter data.How Has This Been Tested?
test/unit/core/utils.jsthat verifyanyOfandoneOfparameter validation for both missing and valid values.utils.jscontinue to pass.Screenshots (if appropriate):
N/A - No UI changes.
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests