Adding CMake version support ranges#14
Merged
etcwilde merged 1 commit intoswiftlang:mainfrom Apr 25, 2025
Merged
Conversation
lrineau
approved these changes
Apr 30, 2024
lrineau
left a comment
lrineau
left a comment
There was a problem hiding this comment.
I approve. cmake_minimum_required with a range of versions is nicer than a set of cmake_policy with the policies set to NEW.
tony-go
approved these changes
Apr 30, 2024
Adding the supported version ranges to each project. The newer versions of CMake have better support with some of the newer policies. Specifically CMP0157 in CMake 3.29 improves the incremental rebuild performance and hooks up the emissions of compile commands for Swift so that folks with Sourcekit-LSP can have a better editing experience.
etcwilde
force-pushed
the
ewilde/update-cmake-versions
branch
from
73b2369 to
d94cde8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the supported version ranges to each project. The newer versions of CMake have better support with some of the newer policies. Specifically CMP0157 in CMake 3.29 improves the incremental rebuild performance and hooks up the emissions of compile commands for Swift so that folks with Sourcekit-LSP can have a better editing experience.