Improve tracking dependencies of header generation.#26
Merged
etcwilde merged 2 commits intoswiftlang:mainfrom Jul 10, 2025
Merged
Improve tracking dependencies of header generation.#26etcwilde merged 2 commits intoswiftlang:mainfrom
etcwilde merged 2 commits intoswiftlang:mainfrom
Conversation
Before: - Build example 3 using `cmake -G Ninja && ninja` - Change include/fibonacci.h - Rebuild using just `ninja` - No build occurs. After: - Follow same steps - Generated header file is emitted afresh
adetaylor
added a commit
to adetaylor/WebKit
that referenced
this pull request
Jul 9, 2025
etcwilde
requested changes
Jul 9, 2025
Member
etcwilde
left a comment
etcwilde
left a comment
There was a problem hiding this comment.
Thank you for your contribution. I've left some comments on changes that should be made before landing this PR.
Contributor
Author
|
Changed as requested and it still seems to work. Let me know if you'd like me to squash the commits or not. Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
cmake -G Ninja && ninjaninjaAfter: