Merged
Conversation
ahoppen
requested review from
allevato,
bnbarham,
shahmishal and
shawnhyam
as code owners
SwiftDiagnostics is imported in swift-format but we didn’t declare a dependency edge in the package manifest.
ahoppen
force-pushed
the
missing-dependency
branch
from
8e51272 to
2ac0eee
Compare
allevato
approved these changes
Apr 24, 2025
Member
allevato
left a comment
allevato
left a comment
There was a problem hiding this comment.
Out of curiosity, is it just a newer toolchain flagging this?
Member
Author
|
It’s just something I noticed while working on some other build infrastructure for swift-format. It isn’t an actual issue in SwiftPM because there is a transitive dependency swift-format -> SwiftFormat -> SwiftParserDiagnostics -> SwiftDiagnostics. But I think it’s cleaner to make it explicit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.