Adding a harness for bouncycastle-rust mldsa#8
Draft
ounsworth wants to merge 1 commit intosymbolicsoft:mainfrom
Draft
Adding a harness for bouncycastle-rust mldsa#8ounsworth wants to merge 1 commit intosymbolicsoft:mainfrom
ounsworth wants to merge 1 commit intosymbolicsoft:mainfrom
Conversation
nadimkobeissi
added a commit
that referenced
this pull request
Apr 12, 2026
All `ML_DSA_Sign` and `ML_DSA_Verify` harness calls now include `("param_set", ps)` in their params, where `ps` is 44, 65, or 87. Previously only `ML_DSA_KeyGen` passed this parameter, and Sign/Verify passed empty params (`&[]`), forcing harness implementations to infer the parameter set from key byte lengths.
This doesn't work for libraries like Bouncy Castle Rust that have distinct types per parameter set (e.g. `MLDSA44`, `MLDSA65`, `MLDSA87`) and need the parameter set upfront to dispatch correctly. So, changed 34 call sites across all 6 battery category files. The `verify()` helper in `category4_verify.rs` gained a `p: &MlDsaParams` parameter to thread the param set through.
Member
|
@ounsworth Could you please check if 38d44c2 helps? |
Author
|
@nadimkobeissi Yup! That looks like it does exactly what I want! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not currently work, 57/60 tests fail with:
the
req: &Requestthat is passed in to handle_sign() and handle_verify(), I need that to contain "param_set" so that I can switch and call MLDSA44, MLDSA65, or MLDSA87.