Skip to content

Invalid value set in uart_init() #59

@rwalle

Description

@rwalle

According to BCM2711 datasheet

https://github.com/babbleberry/rpi4-osdev/blob/c9a2a1429ae7cf0f6d1632c3f4a92fb8457e6c07/part3-helloworld/io.c#L74

Documentation for AUX_MU_LCR_REG says:

Image

Therefore 3 (0b11) is not a valid value, and the correct value should be 1.

https://github.com/babbleberry/rpi4-osdev/blob/c9a2a1429ae7cf0f6d1632c3f4a92fb8457e6c07/part3-helloworld/io.c#L77

0xC6 is not a valid value and does not disable interrupts -- it clears both FIFOs, and the correct value to use is 0x06.

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions