boards: Replace CFLAGS defines with Make variables#531
Merged
Conversation
crawfxrd
force-pushed
the
cflags-configs
branch
2 times, most recently
from
1b1d844 to
65f4348
Compare
Move modifying `CFLAGS` to `common.mk` so that boards only set configs by Make variables. The only remaining use of `CFLAGS` in board Makefiles is for including headers from another directory to minimize duplicate files for model refreshes. This also adds the `CONFIG_` prefix to `CHARGER` and `KBLED`. Test: Build with VERSION=0 is identical. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Remove the default value for the charger to use. Signed-off-by: Tim Crawford <tcrawford@system76.com>
crawfxrd
force-pushed
the
cflags-configs
branch
from
65f4348 to
9017abe
Compare
garrettjwilke
approved these changes
Aug 29, 2025
garrettjwilke
left a comment
garrettjwilke
left a comment
There was a problem hiding this comment.
built every firmware. all built correctly.
flashed and tested on a few laptops. all flashed correctly
jackpot51
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move modifying
CFLAGStocommon.mkso that boards only set configs by Make variables.The only remaining use of
CFLAGSin board Makefiles is for including headers from another directory to minimize duplicate files for model refreshes.This also adds the
CONFIG_prefix toCHARGERandKBLED.Test: Build with
VERSION=0is identical.Resolves: #443