Support for Play 2.6

[JakubKahovec]

Hello,

Do you plan to add support for Play 2.6.x

Thank you

[Daxten]

@t2v 2.6 is out now, will you update this library or will someone has to fork?

best regards

[djx314]

+1

[ezhulkov]

It would be highly appreciated
All of my projects are waiting for play2-auth with 2.6 support
+1

[dancetrain]

Looking forward to see 2.6 play framework support

[gakuzzzz]

Thanks for open this issue.

And I'm sorry about the delay in integration to Play 2.5 over.

We are planning for create play2-auth version2 for Play2.6.

It will be DI based composition instead of mix-in based composition.

Probably it can not keep the source compatibility to play2-auth 0.x.

However I think that it is better way to integrate to current Play2 ecosystem.

I would like to hear your opinions about it.

best regards

[Daxten]

exactly what I thought,
RequestWithAttributes shouldn't be necessary anymore for example (see: https://www.playframework.com/documentation/2.6.x/Highlights26#Request-attributes)

[gakuzzzz]

Yes, the next play2-auth should use the Request attribute API built-in Play2

[ezhulkov]

@gakuzzzz nice news, thank you
Just wondering, how are you going to compose injected actions? Inject many ActionBuilders into Controller and then use something like
builder1 andThen builder2
to get resulting Action?

[Daxten]

Hi,
https://github.com/Daxten/bay-scalajs.g8/blob/e447955c34123e04b0298db931b3e88a14abaa4b/server/app/controllers/Security.scala

this is me just trying out the actionBuilder stuff, but this can create nearly the same syntax then before

I would keep all the builders private or in a nested class and compose them before handing out the dsl to the user

[gakuzzzz]

@ezhulkov @Daxten
This is an annoying problem.
ActionFunctions what have a same Request type can compose each other.
However Different Request type ActionFunctions can not compose.
And ActionBuilders can not compose other ActionBuilder.

To tell the truth, play2-auth has ActionFunctions what partially solves this problem
https://github.com/t2v/play2-auth/blob/master/README.ja.md#actionfunction-%E3%81%A8%E3%81%97%E3%81%A6%E3%81%AE%E5%88%A9%E7%94%A8 (Japanese)

Currently, I think that a better way to compose ActionBuilders is like the action-zipper approach.

[Daxten]

I don't think that should be a problem, you can use a sealed trait for example and create a more generic ActionFunction that way

[gakuzzzz]

@Daxten
play2-auth's ActionBuilder should be enable to compose all ActionBuilders (provided by any libraries which play2-auth does not know)

[Daxten]

Ah! Now I see the problem, yes that's shitty design then by play :/

[ezhulkov]

Agree, action composition in play looks not very convinient

And ActionBuilders can not compose other ActionBuilder.

You can try to compose many ActionBuilders using andThen or compose syntax. Smth like this https://gist.github.com/ezhulkov/90d050a0701206d318999f2995f14472#file-testcontroller-scala-L8

May be it will be better and more concise to have current approach with super() calls and trait chains?

I've forked recently you stackable-controller and put some fixes to support play26 API.
Have not got a chance to get rid of RequestWithAttributes, but it's coming.

https://github.com/zeptolab/stackable-controller/blob/play26/core/src/main/scala/com/zeptolab/play2/stackc/StackableController.scala