Feature: Immersive Jump Label Style and Word Jump#6
Open
zhaocai wants to merge 2 commits intot9md:masterfrom
Open
Feature: Immersive Jump Label Style and Word Jump#6zhaocai wants to merge 2 commits intot9md:masterfrom
zhaocai wants to merge 2 commits intot9md:masterfrom
Conversation
Start word boundary jump ( ignore input stage )
zhaocai
commented
Sep 19, 2016
|
|
||
| z-index : 1; | ||
| color : @smalls-label-color; | ||
| margin-top: -1.5rem; |
Author
There was a problem hiding this comment.
To perfectly overlay labels on text, the value of margin-top: -1.5rem; needs to be slightly tuned for different font and font-size. Do you have any better idea to do this?
Owner
|
@zhaocai Are you still Atom and smalls user? Are you interested in take ownership of this smalls project? I've deprecated and thinking to un-publish from atom package registrory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immersive Jump Label Style
As discussed in issue #5, word-based jump generates too many labels. The result is interruptive due to the sudden emerging of numerous colorful labels. This pull request tunes the style to be relatively more immersive as demonstrated below.
smalls:startWord Jump Implementation and Issues
smalls:word-jumpAs shown in the above screenshot, two issues need to be dealt with.
In addition, the code to implement word jump is not optimal; it is likely need to be refined.