Improve support for valgrind

[jayvdb]

https://formulae.brew.sh/formula/valgrind exists.

Also it looks like CI skips valgrind on the containers because snap is missing. IMO if snap is missing, using the system package for valgrind would be a good fallback.

It doesnt exist on choco yet, and https://sourceforge.net/p/valgrind4win/code/HEAD/tree/ looks dead.

[taiki-e]

https://formulae.brew.sh/formula/valgrind exists.

(It's x86_64 linux-only.)

IMO if snap is missing, using the system package for valgrind would be a good fallback.

That seems reasonable to me.

[jayvdb]

Just fyi, #526 doesnt include valgrind

[gamma0987]

Would you be interested in moving away from snap and instead use a github release of different valgrind builds packed in a tarball? As far as I've seen this would allow the usage of manifest files for better organization.

I just created a small project valgrind-builder because I needed the most recent valgrind versions prebuilt for the ubuntu-24.04 runner. Long story short, these are valgrind builds purely intended for the github ci and directly built from the official valgrind upstream without modifications and additional stuff. Also, I had problems with the snap package because the valgrind headers were missing or didn't match the installed valgrind version. This doesn't happen with valgrind-builder builds. I just had a quick look at the install-action ci and, if you're interested in using valgrind-builder, I could try a pr.

[taiki-e]

I'm no longer installing valgrind via this action and have switched to a different way suitable for cross-testing and no header issue.

I'm actually considering deprecating valgrind support in this action in favor of that.

[gamma0987]

Looks interesting :) But, I actually liked the install-action way although it didn't work for valgrind, yet. What I mean is, I just need the tool and nothing else. If possible, it would be great to keep valgrind but improve it so it works? Like I suggested, I could try a pr.

[taiki-e]

Since there are more security concerns to consider, I do not wish to support tools distributed by anyone other than the tool's developers or the system’s package managers, regardless of whether they are from a trusted third party developer, except for fallbacks that can be disabled.

[gamma0987]

I just wanted to offer it :) However, the Valgrind build in the valgrind-builder repository comes directly from the Valgrind sources, without patches, etc. I don't think there are any major security concerns, although the downloaded source code archive should be verified. I would prefer to have something like this directly from the Valgrind developers, but unfortunately, that's not the case, and most distributions like Ubuntu lag too far behind the official Valgrind version for my taste. If you change your mind, I can add you as a maintainer for valgrind-builder. There isn't much to do except when there is a new Valgrind release, the Ubuntu version on GitHub or the libc version changes. The plan is to create Valgrind builds for the last 5-7 major releases, retrospectively to the current version. However, I haven't made a final decision yet.