Merged
Conversation
github-actions
Bot
added
the
type: fix
…nd update UI to utilize it
…ierarchical detection
amitksingh1490
commented
Oct 24, 2025
…'s Display implementation
… and key-value pairs
Updated the porcelain handling in the UI implementation to use `skip_row(1)` instead of `skip(1)` for better clarity and consistency. This change was applied in multiple locations within the `ui.rs` file to ensure uniform behavior when rendering porcelain output.
…key for consistency
tusharmath
reviewed
Oct 25, 2025
| if porcelain { | ||
| println!("{}", Porcelain::from(&info).into_long().skip(1).drop_col(0)); | ||
| } else { | ||
| println!("{}", info); |
Collaborator
There was a problem hiding this comment.
need to use self.writeln always to print.
tusharmath
reviewed
Oct 25, 2025
| @@ -674,13 +674,7 @@ impl<A: API + 'static, F: Fn() -> A> UI<A, F> { | |||
| .map(|m| m.as_str().to_string()); | |||
| let provider = self.api.get_provider().await.ok().map(|p| p.id.to_string()); | |||
Collaborator
There was a problem hiding this comment.
duplicate logic in handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.