refactor: add timestamp support to TitleFormat for conversation replay#1776
Merged
tusharmath merged 11 commits intomainfrom Nov 8, 2025
Merged
refactor: add timestamp support to TitleFormat for conversation replay#1776tusharmath merged 11 commits intomainfrom
tusharmath merged 11 commits intomainfrom
Conversation
- Add optional timestamp field to TitleFormat struct - Update display logic to use replay timestamp when available, fallback to current time - Add comprehensive tests for timestamp functionality - Maintain backward compatibility for existing code This enables accurate timestamp preservation during conversation replay while keeping current behavior for live conversations.
github-actions
Bot
added
the
type: feature
tusharmath
reviewed
Oct 26, 2025
|
Action required: PR inactive for 5 days. |
github-actions
Bot
added
the
state: inactive
github-actions
Bot
removed
the
state: inactive
tusharmath
reviewed
Nov 3, 2025
| pub category: Category, | ||
| /// Optional timestamp for replay - when set, display logic uses this | ||
| /// instead of current time | ||
| pub timestamp: Option<chrono::DateTime<chrono::Utc>>, |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub timestamp: Option<chrono::DateTime<chrono::Utc>>, | |
| pub timestamp: chrono::DateTime<chrono::Utc>, |
Keep it required.
tusharmath
reviewed
Nov 3, 2025
| let local_time: chrono::DateTime<Local> = timestamp.into(); | ||
| format!("[{}] ", local_time.format("%H:%M:%S")) | ||
| } else { | ||
| // Use current time for live conversations |
Collaborator
There was a problem hiding this comment.
display should only be concerned with formatting and not with generating timestamps.
amitksingh1490
changed the title
amitksingh1490
added
type: chore
tusharmath
reviewed
Nov 6, 2025
| @@ -41,12 +41,9 @@ impl TitleDisplay { | |||
|
|
|||
| // Add timestamp if requested | |||
| if self.with_timestamp { | |||
Collaborator
There was a problem hiding this comment.
don't need this flag anymore.
Contributor
Author
There was a problem hiding this comment.
we need it because you can control if you want to show timestamp in the log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional timestamp support to TitleFormat to enable accurate timestamp preservation during conversation replay.
Usage
This enables the conversation replay system to display timestamps exactly as they occurred during the original conversation, while maintaining current behavior for live conversations.