Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions crates/forge_api/src/forge_api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ impl<A: Services, F: CommandInfra + EnvironmentInfra + SkillRepository + AppConf
}

async fn get_models(&self) -> Result<Vec<Model>> {
Ok(self
.services
.models(
self.get_default_provider()
.await
.context("Failed to fetch models")?,
)
.await?)
// Use AgentProviderResolver to ensure OAuth tokens are refreshed if needed
let agent_provider_resolver = AgentProviderResolver::new(self.services.clone());
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove cred related code from ProviderResolver.

let provider = agent_provider_resolver
.get_provider(None)
.await
.context("Failed to fetch models")?;

Ok(self.services.models(provider).await?)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service should guarantee in this case, that creds will be refreshed. Caller should not be responsible.

}
async fn get_agents(&self) -> Result<Vec<Agent>> {
self.services.get_agents().await
Expand Down
Loading