Skip to content

refactor(display): remove unavailable marker and use empty marker in /provider #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tusharmath merged 3 commits into from
Dec 9, 2025
Merged

refactor(display): remove unavailable marker and use empty marker in /provider #2097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ae2f07
refactor(display): rename unavailable marker to empty marker
amitksingh1490 Dec 9, 2025
af7c46a
refactor(tests): rename unavailable marker to empty marker
amitksingh1490 Dec 9, 2025
dfce7b8
[autofix.ci] apply automated fixes
autofix-ci[bot] Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions crates/forge_main/src/display_constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ pub mod markers {

/// Indicates a built-in (non-user-defined) component
pub const BUILT_IN: &str = "[built-in]";

/// Indicates a resource is unavailable (e.g., provider not configured)
pub const UNAVAILABLE: &str = "[unavailable]";
}

/// Type discriminator for commands, agents, and custom entries.
Expand Down Expand Up @@ -131,8 +128,8 @@ mod tests {
fn test_markers_have_square_brackets() {
assert!(markers::BUILT_IN.starts_with('['));
assert!(markers::BUILT_IN.ends_with(']'));
assert!(markers::UNAVAILABLE.starts_with('['));
assert!(markers::UNAVAILABLE.ends_with(']'));
assert!(markers::EMPTY.starts_with('['));
assert!(markers::EMPTY.ends_with(']'));
}

#[test]
Expand Down
8 changes: 4 additions & 4 deletions crates/forge_main/src/model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ impl Display for CliProvider {
if let Some(domain) = provider.url.domain() {
write!(f, " [{domain}]")?;
} else {
write!(f, " {}", markers::UNAVAILABLE)?;
write!(f, " {}", markers::EMPTY)?;
}
}
AnyProvider::Template(_) => {
write!(f, " {name:<name_width$} {}", markers::UNAVAILABLE)?;
write!(f, " {name:<name_width$} {}", markers::EMPTY)?;
}
}
Ok(())
Expand Down Expand Up @@ -1099,7 +1099,7 @@ mod tests {
});
let formatted = format!("{}", CliProvider(fixture));
let actual = strip_ansi_codes(&formatted);
let expected = format!(" Anthropic {}", markers::UNAVAILABLE);
let expected = format!(" Anthropic {}", markers::EMPTY);
assert_eq!(actual, expected);
}

Expand All @@ -1119,7 +1119,7 @@ mod tests {
});
let formatted = format!("{}", CliProvider(fixture));
let actual = strip_ansi_codes(&formatted);
let expected = format!("✓ Forge {}", markers::UNAVAILABLE);
let expected = format!("✓ Forge {}", markers::EMPTY);
assert_eq!(actual, expected);
}

Expand Down
Loading