fix(app): add doom loop detector to prevent repetitive tool calls#2368
Merged
tusharmath merged 31 commits intomainfrom Mar 11, 2026
Merged
fix(app): add doom loop detector to prevent repetitive tool calls#2368tusharmath merged 31 commits intomainfrom
tusharmath merged 31 commits intomainfrom
Conversation
github-actions
Bot
added
the
type: feature
tusharmath
reviewed
Feb 8, 2026
| Err(err) => ToolResult::new(tool_call.name.as_str()) | ||
| .call_id(tool_call.call_id.clone()) | ||
| .failure(err), | ||
| }; |
Collaborator
There was a problem hiding this comment.
There are errors that we want to propagate back to the agent, and sometimes there are errors that we want to show to the user. In this case that nuance is getting missed.
|
Action required: PR inactive for 5 days. |
github-actions
Bot
added
the
state: inactive
|
PR closed after 10 days of inactivity. |
github-actions
Bot
removed
the
state: inactive
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+161
to
+163
| forge_domain::HandleOperation::AgentError(err) => { | ||
| vec![anyhow::anyhow!("{}", err)] | ||
| } |
Contributor
There was a problem hiding this comment.
Converting Arc<anyhow::Error> to string and back loses the original error type, backtrace, and error chain. This makes debugging difficult in production when doom loop errors occur. The conversion anyhow::anyhow!("{}", err) only preserves the Display output.
Fix by cloning the Arc or using anyhow::Error::msg:
forge_domain::HandleOperation::AgentError(err) => {
vec![(*err).clone()]
}This preserves the full error context for proper error reporting.
Suggested change
| forge_domain::HandleOperation::AgentError(err) => { | |
| vec![anyhow::anyhow!("{}", err)] | |
| } | |
| forge_domain::HandleOperation::AgentError(err) => { | |
| vec![(*err).clone()] | |
| } | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Contributor
Author
There was a problem hiding this comment.
this suggestion won't compile
… Arc instead of converting to string Co-Authored-By: ForgeCode <noreply@forgecode.dev>
tusharmath
reviewed
Mar 11, 2026
| Some((tool_name, count)) | ||
| } | ||
|
|
||
| fn extract_tool_signatures(&self, conversation: &Conversation) -> Vec<(ToolName, String)> { |
Collaborator
There was a problem hiding this comment.
Suggested change
| fn extract_tool_signatures(&self, conversation: &Conversation) -> Vec<(ToolName, String)> { | |
| fn extract_tool_signatures(&self, conversation: &Conversation) -> Vec<(ToolName, ToolCallArguments)> { |
tusharmath
reviewed
Mar 11, 2026
| pub fn detect_from_conversation( | ||
| &self, | ||
| conversation: &Conversation, | ||
| ) -> Option<(ToolName, usize)> { |
Collaborator
There was a problem hiding this comment.
Suggested change
| ) -> Option<(ToolName, usize)> { | |
| ) -> Option<usize> { |
Can just return the index.
tusharmath
changed the title
github-actions
Bot
added
the
type: fix
tusharmath
removed
the
type: feature
tusharmath
added a commit
that referenced
this pull request
Mar 13, 2026
…2368) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: ForgeCode <noreply@forgecode.dev> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a conversation. dump demonstrating dooms loop detection
2026-02-08_19-36-42-dump.html