Skip to content

fix(result_stream): stream reasoning before content in stream #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tusharmath merged 2 commits into from
Feb 16, 2026
Merged

fix(result_stream): stream reasoning before content in stream #2398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2454d7
fix(result_stream): send reasoning before content in stream
laststylebender14 Feb 13, 2026
0f9fde2
Merge branch 'main' into fix/order-of-msg-processing
laststylebender14 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions crates/forge_domain/src/result_stream_ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,28 +77,28 @@ impl ResultStreamExt<anyhow::Error> for crate::BoxStream<ChatCompletionMessage,

// Stream content delta if sender is available
if let Some(ref sender) = sender {
if let Some(content_part) = message.content.as_ref() {
let delta = content_part.as_str();
if let Some(reasoning_part) = message.reasoning.as_ref() {
let delta = reasoning_part.as_str();
if !delta.is_empty() {
// Ignore send errors - the receiver may have been dropped
let _ = sender
.send(Ok(ChatResponse::TaskMessage {
content: ChatResponseContent::Markdown {
text: delta.to_string(),
partial: true,
},
.send(Ok(ChatResponse::TaskReasoning {
content: delta.to_string(),
}))
.await;
}
}

if let Some(reasoning_part) = message.reasoning.as_ref() {
let delta = reasoning_part.as_str();
if let Some(content_part) = message.content.as_ref() {
let delta = content_part.as_str();
if !delta.is_empty() {
// Ignore send errors - the receiver may have been dropped
let _ = sender
.send(Ok(ChatResponse::TaskReasoning {
content: delta.to_string(),
.send(Ok(ChatResponse::TaskMessage {
content: ChatResponseContent::Markdown {
text: delta.to_string(),
partial: true,
},
}))
.await;
}
Expand Down
Loading